Fixing #18659 #18713
Merged
Fixing #18659 #18713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. |
|
Awesome, thanks @juxiliary! |
|
Could you rebase this on master as well to get rid of the merge commit? |
|
This change is the only thing blocking servo's rust upgrade right now. Please p=1 when you r+. |
|
Rabble rabble beat me to it 😜. |
|
@alexcrichton rebased it |
bors
added a commit
that referenced
this pull request
Nov 7, 2014
* `from_str_radix_float` gives incorrect results for negative float strings. Changes the accumulator used to start at -0.0 instead of -1.0. * Adds missing tests
|
Thanks! Really sorry for the trouble I caused :( |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Dec 23, 2024
internal: Cleanup label structure of `CompletionItem`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_str_radix_floatgives incorrect results for negative float strings. Changes the accumulator used to start at -0.0 instead of -1.0.