Implement len() for EnumSet. #18740
Closed
Implement len() for EnumSet. #18740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,6 +91,12 @@ impl<E:CLike> EnumSet<E> { | |||
| EnumSet {bits: 0} | |||
| } | |||
|
|
|||
| /// Return the number of elements in the given `EnumSet`. | |||
|
LGTM, just some style nits. Thanks! |
jbcrail
force-pushed
the
implement-enum-set-len
branch
from
e99195a to
a79d4be
Compare
|
Thanks for the comments! I used your suggestions. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Dec 23, 2024
fix: Fix empty check diagnostics not marking files as changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the missing EnumSet method mentioned by @gankro.
cc #18424