Limit length of metadata decode debug output #19043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
r? @pnkfelix |
| let mut buf = String::new(); | ||
| let end = match max { |
There was a problem hiding this comment.
- You haven't documented anywhere this special handing of
max == 0; (I personally would rather not treat 0 as a special case, and instead pass inmax: Option<uint>, but reasonable people can differ on this sort of detail.) It might be a good idea to note the special case in a note aboveDATA_TRUNCATE. - More important: since every call to
data_log_stringis passing inDATA_TRUNCATE, anddata_log_stringis private to this module, why make it a parameter at all? Why not just useDATA_TRUNCATEdirectly indata_log_string?
There was a problem hiding this comment.
Actually, I changed my mind; I am fine with making the cap a parameter to data_log_string as you did.
|
r=me, though when you rebase, please consider adding a comment with the |
|
Closing due to inactivity, but feel free to reopen with a rebase! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the size of the raw metadata that gets printed when debug logging is enabled.