No index #191
Closed
No index #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I implemented the index update mostly as an exercise. I find it a bit easier to understand, but it must be slower than the current code. |
|
Ah, I didn't see the update from earlier in the week that you added the re-indexing pass. Given that, I'm happy to merge this if it makes the code more legible; though it's now bit-rotted to the point of needing a refresh. |
|
Rebased. Not sure if it more legible, but it is a bit more type safe. |
dlrobertson
pushed a commit
to dlrobertson/rust
that referenced
this pull request
Nov 29, 2018
Fix 'optionaly' typo.
rchaser53
pushed a commit
to rchaser53/rust
that referenced
this pull request
Jan 19, 2019
document keep-stage1 and also try to clarify
djtech-dev
pushed a commit
to djtech-dev/rust
that referenced
this pull request
Dec 9, 2021
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Nov 29, 2024
Towards rust-lang#150 Changes Added harnesses for count_bytes Verification Result ``` Checking harness ffi::c_str::verify::check_count_bytes... VERIFICATION RESULT: ** 0 of 241 failed (5 unreachable) VERIFICATION:- SUCCESSFUL Verification Time: 5.377671s ```
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces indexes with boxes when possible. This might or might not be faster, but I find it a bit easier to read and has stronger typing.