save-analysis: emit names of items that a glob import actually imports. #19254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is useful in itself for DXR-like tools, but it is also a proof of concept for a deglobber tool, which would convert glob imports to proper imports. |
| #[experimental = "Show is experimental."] | ||
| impl<T: fmt::Show> fmt::Show for Weak<T> { | ||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| if self._ptr.is_null() { |
There was a problem hiding this comment.
I don't think this is the right condition to check. The pointer is always valid, and an invalid Weak is indicated by the strong count being 0.
|
@huon yeah, I realised I should have got review for that extra patch. I only included it because I needed it for debugging. I'll pull it out into a separate PR |
|
In order to not break tests I had to change quite a lot of this patch. I also realised there is a breaking change here (I think covered by RFC 116). I think there are enough changes that this needs a re-review, so r? @pcwalton again, please |
| @@ -396,6 +401,13 @@ impl Rib { | |||
| } | |||
| } | |||
|
|
|||
| #[deriving(Show,PartialEq,Clone)] | |||
| enum Shadowable { | |||
There was a problem hiding this comment.
Can you document what this does in a comment?
nrc
force-pushed
the
dxr-glob
branch
2 times, most recently
from
c08775f to
4a407b9
Compare
|
added comment, r? @pcwalton |
nrc
force-pushed
the
dxr-glob
branch
2 times, most recently
from
ed7ab99 to
9d7e2e5
Compare
|
ping for re-r? @pcwalton |
| @@ -341,6 +341,10 @@ pub fn phase_3_run_analysis_passes<'tcx>(sess: Session, | |||
| let lang_items = time(time_passes, "language item collection", (), |_| | |||
| middle::lang_items::collect_language_items(krate, &sess)); | |||
|
|
|||
| let make_glob_map = match save_analysis(&sess) { | |||
|
r=me with one nit |
bors
added a commit
that referenced
this pull request
Dec 18, 2014
There is also some work here to make resolve a bit more stable - it no longer overwrites a specific import with a glob import. r?
There is also some work here to make resolve a bit more stable - it no longer overwrites a specific import with a glob import. [breaking-change] Import shadowing of single/list imports by globs is now forbidden. An interesting case is where a glob import imports a re-export (`pub use`) of a single import. This still counts as a single import for the purposes of shadowing .You can usually fix any bustage by re-ordering such imports. A single import may still shadow (override) a glob import or the prelude.
bors
added a commit
that referenced
this pull request
Dec 27, 2014
There is also some work here to make resolve a bit more stable - it no longer overwrites a specific import with a glob import. r?
bors
added a commit
that referenced
this pull request
Jan 1, 2015
r? @huonw or @alexcrichton Apparently, we have previously rejected an RFC like this. However, since then we removed `{:?}` and so without this debugging gets really difficult as soon as there is a RefCell anywhere, so I believe there is more benefit to adding these impls than there was before. By using "try_borrow" we can avoid panicing in `Show` (I think). @ huon in response to a comment in #19254: I noticed that `drop()` checks for the ptr being null, so I checked here too. Now I am checking for both, if you're confident I can change to only checking `strong()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is also some work here to make resolve a bit more stable - it no longer overwrites a specific import with a glob import.
r?