Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Render Sized? on traits and generics #19272

Merged
merged 3 commits into from
Nov 27, 2014

Conversation

tomjakubowski
Copy link
Contributor

Both trait Foo for Sized? and <Sized? T> are handled correctly.

Fix #18515

@tomjakubowski
Copy link
Contributor Author

(This PR is rebased on #19174 and not master)

@tomjakubowski
Copy link
Contributor Author

Rendered docs here: http://homer.crystae.net/19272/doc/std/cmp/trait.PartialOrd.html

That page should have uses of Sized? in both a trait bound and in a type parameter bound.

@alexcrichton
Copy link
Member

Awesome, thanks @tomjakubowski!

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 24, 2014
At the same time remove the `pub use` of the variants in favor of accessing
through the enum type itself. This is a breaking change as the `Found` and
`NotFound` variants must now be imported through `BinarySearchResult` instead of
just `std::slice`.

[breaking-change]
Closes rust-lang#19272
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 27, 2014
Both `trait Foo for Sized?` and `<Sized? T>` are handled correctly.

Fix rust-lang#18515
@bors bors merged commit 59d1382 into rust-lang:master Nov 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustoc doesn't display "for Sized?" on traits
3 participants