Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the same llvmdeps.rs for every host. #19322

Merged
merged 3 commits into from
Nov 27, 2014

Conversation

DiamondLovesYou
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@alexcrichton
Copy link
Member

Oh man, I forgot that we could fix this now, this is awesome!

@alexcrichton
Copy link
Member

Could this also remove support in src/etc/mklldeps.py for emitting multiple extern blocks? Thanks!

@DiamondLovesYou
Copy link
Contributor Author

😄 Sweet!

Huh. The only reason I created this was because I thought mklldeps didn't handle cross-compiled hosts. It must of been that llvmdeps.rs wasn't regenerated after a configure. Le shrug.

@DiamondLovesYou
Copy link
Contributor Author

Oh, done!

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 27, 2014
@bors bors merged commit ce507c6 into rust-lang:master Nov 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants