Add test for #18908 #19377
Merged
Add test for #18908 #19377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gankro Here's your test, sorry for the delay. |
|
r+? @alexcrichton |
|
Thanks for remembering! ❤️ |
| } | ||
| } | ||
| const NUM_ELEMENTS: uint = 2; | ||
| static in_test: AtomicBool = atomic::INIT_ATOMIC_BOOL; |
There was a problem hiding this comment.
That the test isn't accidently run twice in parallel.
There was a problem hiding this comment.
Interesting. Is that an actual concern for our teating framework?
There was a problem hiding this comment.
I'm not sure, maybe someone who knows it could comment on it?
There was a problem hiding this comment.
Currently the testing framework guarantees that a test is only run once for each test run, so it's probably ok to remove this. We've got a good number of tests elsewhere that aren't threadsafe to run in parallel either (use of static mut globals similarly).
tbu-
force-pushed
the
pr_mapinplace_fixzerosized_test
branch
from
3cbddd2 to
807066f
Compare
bors
added a commit
that referenced
this pull request
Dec 11, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.