-
Notifications
You must be signed in to change notification settings - Fork 13.3k
"The Rust Programming Language" #19461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this is probably too simple, but it'll work for now
I haven't had a lot of love for Rustbook's stability and style as used on aturon's style guide. However your build seems considerably more stable, did you do anything different? Style things can of course be worked out. Like the general direction, though. This is a much more coherent vision for our high-level documentation. |
@gankro what do you mean by 'stable' in this context? |
http://aturon.github.io/ frequently flickers the content or will just not load it at all. Actually it just seems totally broken to me now. Possibly just bitrot? Has the official version been moved? |
Loads just fine here. Odd. I just built it with my own compiled version. But as you say, style is fixable regardless. Sent from my iPhone
|
Loads and looks fine on my end as well... |
Hmm, whenever I click on a menu item the page just goes white. I have to refresh to get it to actually render :/ (on aturon's not yours). |
This would be one of the problems, where one's results will wary greatly depending on what fonts, browser, packages they have/not have installed etc. sigh |
I'd like to take some time to think about how the build and automation around such a change will work before we merge. The font problem with the docs in general is frustrating. Maybe we should get rid of Fira and use a more typical local font until the bug is figured out. |
Great Job. |
AFAICT, it’s an Arch Linux-specific bug that has little to do with configuration. |
@adrientetar It may be, but it's similar in nature nonetheless. (the same thing showing up differently depending on your system) |
I get Not sure if it’s related but it looks like that needs fixing server-side: http://stackoverflow.com/questions/15521130/google-warning-resource-interpreted-as-font-but-transferred-with-mime-type-appl |
@adrientetar that is worrisome! Our instance of doc.rust-lang.org actually just proxies requests to S3, and it looks like when publishing docs to S3 (using s3cmd) there's no way to instruct it that these |
I do not use nginx. Can you pass the MIME type manually with -m to s3cmd? |
@gankro Could be corrupted browser profile. See rust-lang/rust-by-example#201 (comment) if it's an issue in firefox. Other browsers probably have cleaning instructions as well. |
@mdinger I tried with a fresh profile, it still happens. |
@MatejLach Ah, I didn't notice that you and @gankro were describing the same issue. That makes sense then. |
This no longer cleanly merges, and I intend to revamp the Tasks guide before merging this all together anyway, so I'm giving this PR a close for now. @brson let's tallk automation sometime soon as well. |
An updated version of rust-lang#19461 This version vendors steveklabnik/rustbook@731f7bf and builds it when building the docs. This is almost great, except my `make`-foo is poor, so I have my own personal paths in `mk/docs.mk`. How should I best get around that? /cc @brson
This is a preliminary PR that significantly changes Rust's documentation.
TL;DR: Remove the distinction between "the guide" and "the guides", and merge them into one big 'ol "The Rust Programming Language." You can see it rendered here: http://steveklabnik.github.io/the_rust_programming_language/
This uses https://github.com/aturon/rust-book to generate said final product.
Basically, the new "book" as I'm calling it looks like this:
Part I: Basics <- this is the first half of the current Guide. Linear.
Part II: Intermediate <- this is some of the current Guide, with the invididual Guides replacing chapters where relevant. Can be read in any order.
Part III: Adavanced <- the most advanced of the previous Guides. Can be read in any order.
Conceivably, this could even fix rust-lang/rust-by-example#278 by making Rust by example a part IV or something. While Rust By Example doesn't currently use Rustbook, it could.
I don't think the
Makefile
is currently up to snuff, but it works, at least. Ish. Feedback very welcome.This also adds an optional dependency on rustbook, which may not be something that we want.