replace 'but' with 'and' #19462
Merged
replace 'but' with 'and' #19462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me if you also remove the comma. |
MatejLach
force-pushed
the
but-and_guide
branch
from
3557f9a to
ebf22cb
Compare
|
@steveklabnik removed. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 28, 2025
refactor: Lower type-refs before type inference
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 28, 2025
That is, all queries that have a `with_diagnostic` variant. Them being tracked was (maybe) needed before rust-lang#19462, because back then diagnostics could refer `AstId`s (for macro types), but now they are no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
andhere instead ofbutsounds better to me, as but makes it sound like an item which is still under active development shouldn't normally require more testing, but this one does - or something like that :-)@steveklabnik?