Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capacity-related functions for VecMap #19523

Closed

Conversation

aliblong
Copy link
Contributor

@aliblong aliblong commented Dec 4, 2014

Part of #18424

Adds functions reserve(uint), reserve_exact(uint), and capacity() to VecMap, as per the collections reform.

(Separation of PRs from #19516)

@Gankra
Copy link
Contributor

Gankra commented Dec 4, 2014

I believe this is one place where our original plans as accepted in the RFC diverge from how we actually plan to do it. The new plans need to be accepted in a new RFC though. I am working on it with @aturon but we're both occupied for the next little-while.

While this patch seems to be more-or-less correct, I'd like to sit on it while we hash out conventions.

Sorry :(

@aliblong
Copy link
Contributor Author

aliblong commented Dec 4, 2014

Okay, I'll close this for now, since I suspect the final version of capacity reservation for VecMap will look more like reserve_index than reserve.

@aliblong aliblong closed this Dec 4, 2014
@aliblong aliblong deleted the add_vecmap_reserve_functions branch December 4, 2014 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants