work around portability issue on FreeBSD, in which the key returned from #19577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pthread_key_create can be 0.
|
Thanks for the PR! Would it be possible to just +1 to all keys received instead of creating two keys? |
|
As a practical matter, I think that would work on any sane platform (though it would impose a run-time cost of subtracting 1 from the stored value each time you try to actually use the key). From a pure portability standpoint, does the POSIX standard allow the created key to be -1? I think it does, which would mean the portability issue still exists (though it's much more difficult to imagine a platform that would actually return -1). To my mind, a better solution involves not having a reserved value for the key, though I'm not sure how that would work... |
|
Sounds good to me, thanks @aidancully! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 9, 2014
pthread_key_create can be 0. addresses issue rust-lang#19567.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pthread_key_create can be 0.
addresses issue #19567.