Make MemoryMap use HANDLE on Windows. #19620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retep998
force-pushed
the
memorymap
branch
2 times, most recently
from
2c8f649 to
b7ee796
Compare
Also fixes some conflicting module names. Signed-off-by: Peter Atashian <retep998@gmail.com>
|
In general |
| @@ -159,7 +159,7 @@ pub fn getcwd() -> IoResult<Path> { | |||
| } | |||
|
|
|||
| #[cfg(windows)] | |||
| pub mod windows { | |||
| pub mod windoze { | |||
There was a problem hiding this comment.
Is this renaming intentional? I guess this is due to the collision with #[cfg(windows)] pub use sys::ext as windows;, but then the only function here seems misplaced.
There was a problem hiding this comment.
I have a branch that's refactoring this into the actual windows module, so I'm not too worried about this temporary state of affairs.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 9, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.