Extend<&str> and FromIterator<&str> for String #19626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2014 21:31
&str is a "particle" of a string already, see the graphemes iterator, so it seems natural that we should be able to use it with Extend.
bluss
force-pushed
the
string-extend-str
branch
2 times, most recently
from
fe83d98 to
976c658
Compare
bluss
force-pushed
the
string-extend-str
branch
from
976c658 to
a813469
Compare
|
This will need an RFC. |
|
cc @gankro |
|
I do not think this needs an RFC. the RFCs repo states that an RFC is for a substantial change and I do not think this change requires one. @aturon thoughts on this? |
|
Yeah, this is quite minor and we could accept a PR for it without an RFC. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 9, 2014
Strings iterate to both char and &str, so it is natural it can also be extended or collected from an iterator of &str. Apart from the trait implementations, `Extend<char>` is updated to use the iterator size hint, and the test added tests both the char and the &str versions of Extend and FromIterator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings iterate to both char and &str, so it is natural it can also be extended or collected from an iterator of &str.
Apart from the trait implementations,
Extend<char>is updated to use the iterator size hint, and the test added tests both the char and the &str versions of Extend and FromIterator.