Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up libcollections::VecMap #19663

Merged
merged 2 commits into from
Dec 10, 2014
Merged

Clean up libcollections::VecMap #19663

merged 2 commits into from
Dec 10, 2014

Commits on Dec 9, 2014

  1. Clean up libcollections::VecMap 

    - Introduce a named type for the return type of `VecMap::move_iter`
- Rename all type parameters to `V` for "Value".
- Remove unnecessary call to an `Option::unwrap`, use pattern matching instead.
- Remove incorrect `Hash` implementation which took the `VecMap`'s capacity
  into account.

This is a [breaking-change], however whoever used the `Hash` implementation
relied on an incorrect implementation.
    @tbu-
    tbu- committed Dec 9, 2014
    Configuration menu
    Copy the full SHA
    67ae3a4 View commit details
    Browse the repository at this point in the history

  2. Add a proper Hash implementation for VecMap 

    Also re-add the previously deleted test with an additional test that would have
failed before, when the hash function depended on the capacity.
    @tbu-
    tbu- committed Dec 9, 2014
    5 Configuration menu
    Copy the full SHA
    20eaf16 View commit details
    Browse the repository at this point in the history