Skip to content

Add coercions from *mut to *const and from &mut to *const. #19766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/librustc/middle/infer/coercion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -549,17 +549,18 @@ impl<'f, 'tcx> Coerce<'f, 'tcx> {
b.repr(self.get_ref().infcx.tcx));

let mt_a = match *sty_a {
ty::ty_rptr(_, mt) => mt,
ty::ty_rptr(_, mt) | ty::ty_ptr(mt) => mt,
_ => {
return self.subtype(a, b);
}
};

// Check that the types which they point at are compatible.
// Note that we don't adjust the mutability here. We cannot change
// the mutability and the kind of pointer in a single coercion.
let a_unsafe = ty::mk_ptr(self.get_ref().infcx.tcx, mt_a);
let a_unsafe = ty::mk_ptr(self.get_ref().infcx.tcx, ty::mt{ mutbl: mutbl_b, ty: mt_a.ty });
try!(self.subtype(a_unsafe, b));
if !can_coerce_mutbls(mt_a.mutbl, mutbl_b) {
return Err(ty::terr_mutability);
}

// Although references and unsafe ptrs have the same
// representation, we still register an AutoDerefRef so that
Expand Down
24 changes: 24 additions & 0 deletions src/test/compile-fail/ptr-coercion.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test coercions between pointers which don't do anything fancy like unsizing.
// These are testing that we don't lose mutability when converting to raw pointers.

pub fn main() {
// *const -> *mut
let x: *const int = &42i;
let x: *mut int = x; //~ERROR values differ in mutability

// & -> *mut
let x: *mut int = &42; //~ERROR values differ in mutability

let x: *const int = &42;
let x: *mut int = x; //~ERROR values differ in mutability
}
35 changes: 35 additions & 0 deletions src/test/run-pass/ptr-coercion.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test coercions between pointers which don't do anything fancy like unsizing.

pub fn main() {
// &mut -> &
let x: &mut int = &mut 42i;
let x: &int = x;

let x: &int = &mut 42i;

// & -> *const
let x: &int = &42i;
let x: *const int = x;

let x: *const int = &42i;

// &mut -> *const
let x: &mut int = &mut 42i;
let x: *const int = x;

let x: *const int = &mut 42i;

// *mut -> *const
let x: *mut int = &mut 42i;
let x: *const int = x;
}