Move hash module from collections to core #19800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like there are some tidy errors with coretest, and can you also make sure these files are included in coretest as well? I didn't see the Other than that though, r=me, thanks! |
Member
|
Ah also, you may be able to change the hash implementations for some the core types like Option/Result to use |
sfackler
force-pushed
the
core-hash
branch
2 times, most recently
from
fec7e2f to
2c4effd
Compare
bors
added a commit
that referenced
this pull request
Dec 14, 2014
Move hash module from collections to core Reviewed-by: alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton