Detect type inference failure when auto-dereferencing a pointer #19813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barosl
force-pushed
the
autoderef-type-inference-ice
branch
from
aa01242 to
bf3bbd2
Compare
|
It seems that #19583 was also caused by this bug. |
barosl
force-pushed
the
autoderef-type-inference-ice
branch
2 times, most recently
from
34a8fee to
d5cf71c
Compare
barosl
force-pushed
the
autoderef-type-inference-ice
branch
from
d5cf71c to
14c01dd
Compare
barosl
force-pushed
the
autoderef-type-inference-ice
branch
from
14c01dd to
18bc8a1
Compare
|
or r? @pnkfelix (or other wizards in this area) |
barosl
force-pushed
the
autoderef-type-inference-ice
branch
from
18bc8a1 to
df31e32
Compare
check::autoderef() returns a ty_err when it fails to infer the type.
probe::probe() should respect this failure and fail together to prevent
further corruption.
Call stack: check::check_method_call() -> method::lookup() ->
probe::probe() + confirm::confirm()
Fixes rust-lang#19692.
Fixes rust-lang#19583.
Fixes rust-lang#19297.
barosl
force-pushed
the
autoderef-type-inference-ice
branch
from
df31e32 to
d9f3067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check::autoderef()returns aty_errwhen it fails to infer the type.probe::probe()should respect this failure and fail together to prevent further corruption.Fixes #19692.
Fixes #19583.
Fixes #19297.