Initial version of AArch64 support. #20017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks for this- I'm working on a power port and this is a pretty good todo list for things I have left! |
| let val = 0xdeadbeef_deadbeef_u64; | ||
| assert_eq!(hash(&(val as u64)), hash(&(val as uint))); | ||
| assert!(hash(&(val as u32)) != hash(&(val as uint))); | ||
| } |
There was a problem hiding this comment.
Can't the 32-bit and 64-bit architectures reuse the same tests, one for each?
There was a problem hiding this comment.
It seems/seemed to me that they could. However, I didn't want/dare to go against the practice I found here: fn test_hash_uint() is already cloned for arm and x86 targets, that's why I added a new version for aarch64, cloning the x86_64 version. Shall the refactoring (merging the clones) be part of this patch (which will make it not purely aarch64-focused)?
akosthekiss
force-pushed
the
pr-aarch64-src
branch
from
598b6ef to
a50ed7e
Compare
|
Rolled, so closing this PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some FIXMEs in the code (around thread locals and stack protection) but rustc already passes most of the tests on AArch64:
summary of 41 test runs: 8265 passed; 1 failed; 542 ignored; 0 measured.
Needs #19790 and rust-lang/compiler-rt#5 .