std: Re-enable at_exit() #20045
Merged
std: Re-enable at_exit() #20045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @aturon |
alexcrichton
force-pushed
the
issue-20012
branch
from
8a202eb to
e7d41b8
Compare
alexcrichton
force-pushed
the
issue-20012
branch
from
e7d41b8 to
67cafac
Compare
alexcrichton
force-pushed
the
issue-20012
branch
from
67cafac to
c1cf0b8
Compare
alexcrichton
force-pushed
the
issue-20012
branch
from
c1cf0b8 to
6832ad1
Compare
alexcrichton
force-pushed
the
issue-20012
branch
7 times, most recently
from
277fc06 to
dc2adcc
Compare
alexcrichton
force-pushed
the
issue-20012
branch
5 times, most recently
from
d481146 to
a61868f
Compare
The new semantics of this function are that the callbacks are run when the *main thread* exits, not when all threads have exited. This implies that other threads may still be running when the `at_exit` callbacks are invoked and users need to be prepared for this situation. Users in the standard library have been audited in accordance to these new rules as well. Closes rust-lang#20012
alexcrichton
force-pushed
the
issue-20012
branch
from
a61868f to
9e224c2
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 31, 2014
The new semantics of this function are that the callbacks are run when the *main thread* exits, not when all threads have exited. This implies that other threads may still be running when the `at_exit` callbacks are invoked and users need to be prepared for this situation. Users in the standard library have been audited in accordance to these new rules as well. Closes rust-lang#20012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new semantics of this function are that the callbacks are run when the main
thread exits, not when all threads have exited. This implies that other threads
may still be running when the
at_exitcallbacks are invoked and users need tobe prepared for this situation.
Users in the standard library have been audited in accordance to these new rules
as well.
Closes #20012