Skip to content

Support multiple lifetime bounds in where clauses #20067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jroesch
Copy link
Member

@jroesch jroesch commented Dec 20, 2014

r? @nikomatsakis I was working on this in between compiles today, and wanted to submit another PR. This fixes #20049 and is a follow up that should be applied after #20002. @tomjakubowski this should unblock #20048. As always any feedback is appreciated.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@jroesch
Copy link
Member Author

jroesch commented Dec 20, 2014

All the changes are contained in this commit:
jroesch@a1cd275

Implement support in the parser for generalized where clauses,
as well as the conversion of ast::WherePredicates to
ty::Predicate in `collect.rs`.
@jroesch jroesch force-pushed the multiple-lifetime-bounds branch from a1cd275 to 8aa18ae Compare December 20, 2014 10:25
@jroesch
Copy link
Member Author

jroesch commented Dec 20, 2014

This should be handled completely by #20002 now.

@jroesch jroesch closed this Dec 20, 2014
@nikomatsakis
Copy link
Contributor

Closing in favor of #20002 (this commit is rolled in)

@nikomatsakis
Copy link
Contributor

oh, @jroesch you beat me to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse multiple bounding lifetimes in where clauses
3 participants