Support all variants of WherePredicate in clean/mod.rs #20180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
Adds support for all variants of ast::WherePredicate in clean/mod.rs. Fixes rust-lang#20048, but will need modification when EqualityPredicates are fully implemented in rust-lang#20041.
jroesch
force-pushed
the
clean-where-predicate
branch
from
9ee30b7
to
6948a2d
Compare
|
This needs a test case, yeah? |
|
It could have a test but rustdoc tests are pretty awful to write (the existing ones are Makefiles that call grep, pretty much). |
| let bounds = pred.bounds.as_slice(); | ||
| try!(write!(f, "{}: {}", pred.ty, TyParamBounds(bounds))); | ||
| match pred { | ||
| &clean::WherePredicate::BoundPredicate {ref ty, ref bounds } => { |
There was a problem hiding this comment.
nit: should have a space between { and ref
|
@tomjakubowski @tamird I am always happy to have more tests if you think it is worth the time. I have plenty of downtime during compilation/debug cycles. I addressed your nit, and removed the commas between the match arms since they are just noise when using |
|
@jroesch The tests that check rustdoc's output are in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for all variants of ast::WherePredicate in clean/mod.rs. Fixes #20048, but will need modification when EqualityPredicates are fully implemented in #20041.