Make lexer tests runable again #20245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks for this! cc @cmr, the original author of this infrastructure |
|
Looks great thanks! The purpose of verify.rs is to print out tokens in the same way as the antlr tool to compare their output, to ensure the model matches reality. |
fhahn
force-pushed
the
make-lexer-tests-runable-again
branch
from
e8a07cf to
adda899
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 30, 2014
I would like to look into some issues related to the model lexer rust-lang#15883. I stumbled upon 2 minor problems when I tried running the lexer tests: * antlr did not put the generated files in the correct directory * grammer/verify.rs did not work with the most recent version of rust With these changes (and setting CLASSPATH=/usr/share/java/antlr-4.4-complete.jar:$CLASSPATH) I was able to execute the tests. Note that I just fixed the syntax errors and added `None` as 2. argument of `Literal`. I am not sure if this is correct however. I still have to take a closer look at what verify.rs actually does. Are there any helpful pointers?
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 30, 2014
This patch for rust-lang#15877 uses Antlr's input lookahead (`_input.LA(1) != '.'`) to solve the conflict between the LIT_FLOAT and the range syntax. Note that in order to execute the grammar tests, rust-lang#20245 should land first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to look into some issues related to the model lexer #15883.
I stumbled upon 2 minor problems when I tried running the lexer tests:
With these changes (and setting CLASSPATH=/usr/share/java/antlr-4.4-complete.jar:$CLASSPATH) I was able to execute the tests.
Note that I just fixed the syntax errors and added
Noneas 2. argument ofLiteral. I am not sure if this is correct however. I still have to take a closer look at what verify.rs actually does. Are there any helpful pointers?