-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntax for negative implementations of traits #20285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks good but I think it needs:
|
flaper87
force-pushed
the
oibit-send-and-friends
branch
from
December 29, 2014 11:52
ea5ed28
to
e9334ea
Compare
@nikomatsakis erm, it looks like I forgot to |
flaper87
force-pushed
the
oibit-send-and-friends
branch
from
December 29, 2014 13:05
e9334ea
to
336a8e6
Compare
@nikomatsakis I went with something a bit longer but clearer |
r+ if nits are fixed and commit 336a836 is dropped |
flaper87
force-pushed
the
oibit-send-and-friends
branch
7 times, most recently
from
December 30, 2014 20:11
04413e7
to
5fdd809
Compare
@nikomatsakis rebased r? :) |
flaper87
force-pushed
the
oibit-send-and-friends
branch
from
January 3, 2015 13:05
5fdd809
to
73fb1ab
Compare
@nikomatsakis rebased r? |
flaper87
force-pushed
the
oibit-send-and-friends
branch
from
January 4, 2015 09:33
73fb1ab
to
5ee5727
Compare
flaper87
force-pushed
the
oibit-send-and-friends
branch
from
January 4, 2015 14:50
5ee5727
to
42fe3c2
Compare
This commit introduces the syntax for negative implmenetations of traits as shown below: `impl !Trait for Type {}` cc rust-lang#13231 Part of RFC rust-lang#3
flaper87
force-pushed
the
oibit-send-and-friends
branch
from
January 4, 2015 22:16
42fe3c2
to
c062fac
Compare
bors
added a commit
that referenced
this pull request
Jan 5, 2015
…tsakis This commit introduces the syntax for negative implementations of traits as shown below: `impl !Trait for Type {}` cc #13231 Part of RFC rust-lang/rfcs#127 r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the syntax for negative implementations of traits
as shown below:
impl !Trait for Type {}
cc #13231
Part of RFC rust-lang/rfcs#127
r? @nikomatsakis