Make all integers in the guide i32, implicitely
#20428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thank you so much. I saw fallback landed and I was going to do this, but I decided to make breakfast first. I'm glad I did! I'll give this a review after I'm done eating 😄 |
|
Needs a rebase |
The guide still needs to talk about integer suffixes.
tbu-
force-pushed
the
pr_guide_int_to_i32_2nd_take
branch
from
31117c3
to
5de7804
Compare
|
@steveklabnik Rebased. |
bors
added a commit
that referenced
this pull request
Jan 4, 2015
Make all integers in the guide `i32`, implicitely Reviewed-by: steveklabnik
bors
referenced
this pull request
Jan 4, 2015
bors
added a commit
that referenced
this pull request
Jan 4, 2015
Make all integers in the guide `i32`, implicitely Reviewed-by: steveklabnik
bors
referenced
this pull request
Jan 4, 2015
|
\o/ No more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guide still needs to talk about integer suffixes.