Associated type region bounds and miscellaneous ICEs #20465
Merged
+330
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aturon let me know if you don't feel qualified to review. I'm picking on you lately for some reason. |
nikomatsakis
changed the title
|
r=me after a rebase |
…egion bounding. Fixes rust-lang#20303. Strictly speaking, this is a [breaking-change] (if you are using associated types). You are no longer free to wantonly violate the type system rules by closing associated types into objects without any form of region bound. Instead you should add region bounds like `T::X : 'a`, just as you would with a normal type parameter.
nikomatsakis
force-pushed
the
assoc-types-regions-20303
branch
from
08c82a4 to
b540f96
Compare
…n the other compiler passes. Fixes rust-lang#17359.
nikomatsakis
force-pushed
the
assoc-types-regions-20303
branch
from
b540f96 to
5caf847
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 6, 2015
Treat associated types the same as type parameters when it comes to region bounding. Fixes rust-lang#20303. Strictly speaking, this is a [breaking-change] (if you are using associated types). You are no longer free to wantonly violate the type system rules by closing associated types into objects without any form of region bound. Instead you should add region bounds like `T::X : 'a`, just as you would with a normal type parameter. r? @aturon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat associated types the same as type parameters when it comes to region bounding. Fixes #20303.
Strictly speaking, this is a [breaking-change](if you are using
associated types). You are no longer free to wantonly violate the type
system rules by closing associated types into objects without any form
of region bound. Instead you should add region bounds like
T::X : 'a, just as you would with a normal type parameter.r? @aturon