Register new snapshot, use slicing syntax everywhere #20721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2015 17:15
|
@japaric Amazing! I think we should consider removing the |
|
Just noticed that I need to update a lot of |
|
LGTM |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 8, 2015
Conflicts: src/libcollections/vec.rs src/libcore/fmt/mod.rs src/librustc/lint/builtin.rs src/librustc/session/config.rs src/librustc_trans/trans/base.rs src/librustc_trans/trans/context.rs src/librustc_trans/trans/type_.rs src/librustc_typeck/check/_match.rs src/librustdoc/html/format.rs src/libsyntax/std_inject.rs src/libsyntax/util/interner.rs src/test/compile-fail/mut-pattern-mismatched.rs
|
btw, #20720 fixes the precedence issue with ranges, so where we currently have to use parens, you won't need to. E.g, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Index[Mut]traits from the prelude (which were temporarily added to help landing a PR). Note that you don't need to have those traits in scope to use the indexing sugar.[breaking-change]
(I didn't address the
NOTE(stage0)comments that didn't involve a#[cfg(stage0)]attribute in this PR (all of them are related toString/Show). However, I did try the changes specified in those comments in a local build but that ended breakingcompiletestwhich resulted in ~1500 failed cfail tests, and I didn't investigate further. @seanmonstar you may want to look into it.)r? @nick29581 / @alexcrichton