-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature gate box syntax #20723
Feature gate box syntax #20723
Conversation
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
(i'm still doing a local |
argh still need to pepper more crates with |
…otstrap. To avoid using the feauture, change uses of `box <expr>` to `Box::new(<expr>)` alternative, as noted by the feature gate message. (Note that box patterns have no analogous trivial replacement, at least not in general; you need to revise the code to do a partial match, deref, and then the rest of the match.) [breaking-change]
Specifically added to the test, librustc_trans, librustc_typeck crates.
…in various tests.
…tax in various tests.
feature gate net. fix typo in my feature-gate-box-expr.rs test.
@pnkfelix Talking more with the rest of the core team, we actually feel like |
0d4baae
to
3010e10
Compare
(Thanks for getting this out so quickly btw!) |
(still waiting on a local make check; but i'll be tagging this with r=huonw once that is done) |
…new` instead in the future.)
…ox::new` instead.)
… as prior two commits.)
(handing off to acrichto to deal with remaining fallout as part of rollup) |
Conflicts: src/compiletest/compiletest.rs src/libcollections/lib.rs src/libserialize/lib.rs src/libsyntax/feature_gate.rs
Rollup merge (373cbab) of PR rust-lang#20723 accidentally reverted a portion of commit 8327bcc which shifted `slicing_syntax` from Active to Accepted.
…cepted, r=nikomatsakis Rollup merge (373cbab) of PR rust-lang#20723 accidentally reverted a portion of commit 8327bcc which shifted `slicing_syntax` from Active to Accepted.
…cepted, r=nikomatsakis Rollup merge (373cbab) of PR rust-lang#20723 accidentally reverted a portion of commit 8327bcc which shifted `slicing_syntax` from Active to Accepted.
…cepted, r=nikomatsakis Re-tag `slicing_syntax` as `Accepted`. Rollup merge (373cbab) of PR rust-lang#20723 accidentally reverted a portion of commit 8327bcc which shifted `slicing_syntax` from Active to Accepted.
…cepted, r=nikomatsakis Re-tag `slicing_syntax` as `Accepted`. Rollup merge (373cbab) of PR rust-lang#20723 accidentally reverted a portion of commit 8327bcc which shifted `slicing_syntax` from Active to Accepted.
As part of the audit for rust-lang#22820 the following duplicate feature gate tests were removed: * `box_patterns` * `simd_ffi` These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578, however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively. r? @nrc
As part of the audit for rust-lang#22820 the following duplicate feature gate tests were removed: * `box_patterns` * `simd_ffi` These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578, however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively. r? @nrc
As part of the audit for rust-lang#22820 the following duplicate feature gate tests were removed: * `box_patterns` * `simd_ffi` These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578, however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively. r? @nrc
Added
box_syntax
feature gate; added to std and rustc crates for bootstrap.To avoid using the feature, change uses of
box <expr>
toBox::new(<expr>)
alternative, as noted by the feature gate message.(Note that box patterns have no analogous trivial replacement, at least not in general; you need to revise the code to do a partial match, deref, and then the rest of the match.)
[breaking-change]