Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new number literal suffixes to Vim syntax highlighting #20881

Merged
merged 2 commits into from
Jan 12, 2015

Conversation

brookst
Copy link
Contributor

@brookst brookst commented Jan 10, 2015

Just a quick addition of is and us suffixes.

At some point the i and u only suffixes should be dropped, along with the int and uint types.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@ftxqxd
Copy link
Contributor

ftxqxd commented Jan 11, 2015

I'd personally advocate the removal of the i and u suffixes (and int and uint) immediately. They're already deprecated, so it’d just be extra work that could be incorporated into one (this) PR. Disabling syntax highlighting for them is also a good way of showing that they’re no longer valid.

@brookst
Copy link
Contributor Author

brookst commented Jan 11, 2015

Sure, I've removed int, uint, i and u suffixes.

Also took the liberty of removing the range function since we have range notation now.

bors added a commit that referenced this pull request Jan 12, 2015
Add new number literal suffixes to Vim syntax highlighting

Reviewed-by: alexcrichton
@bors bors merged commit 4c78d28 into rust-lang:master Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants