Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix string multi line connector '\' for kate syntax rust.xml #21123

Merged
merged 1 commit into from
Jan 21, 2015

Conversation

visualfc
Copy link
Contributor

example:
let m = "hello
world";

example:
let m = "hello \
           world";
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@bombless
Copy link
Contributor

Glad I am not the only one who use kate to write Rust source.

I plan to add traits from here and here to the traits list.

For

  1. The traits list is outdated, it does not include traits like Clone
  2. It looks weird if you type #[derive(Copy, String)], when Copy is bold and String is not

I will make a PR once this is merged.

Wait, @visualfc I know you! I even made a PR for liteide. Thanks for your works on liteide!

@bombless
Copy link
Contributor

cc @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+ 935b37a rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 19, 2015
barosl added a commit to barosl/rust that referenced this pull request Jan 20, 2015
@bors bors merged commit 935b37a into rust-lang:master Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants