Skip to content

Conversation

@aidanhs
Copy link
Contributor

@aidanhs aidanhs commented Jan 15, 2015

...to make it slightly clearer that there's not much point in boxing a vec.

On a different note, I read the contribution guidelines (https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#pull-request-procedure) which say I should update the copyright date for this file. But I can see that nobody else has done this so far this year, despite there being a fair number of commits.

Does that instruction need removing?

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@aidanhs
Copy link
Contributor Author

aidanhs commented Jan 15, 2015

Re-wrapped to 99 chars per style.

@brson
Copy link
Contributor

brson commented Jan 15, 2015

@aidanhs The issue of updating the copyright date is pretty fuzzy. It's kind of a best-effort thing. Personally I usually don't bother. I'm not sure whether we should change the contributing file or not.

@aidanhs
Copy link
Contributor Author

aidanhs commented Jan 15, 2015

I guess if it needs to be done eventually then it can be left in there.

bors added a commit that referenced this pull request Jan 15, 2015
Doc tweak: explicitly state that vector contents are on the heap

Reviewed-by: brson, steveklabnik
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 15, 2015
...to make it slightly clearer that there's not much point in boxing a vec.

On a different note, I read the contribution guidelines (https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#pull-request-procedure) which say I should update the copyright date for this file. But I can see that nobody else has done this so far this year, despite there being a fair number of commits.

Does that instruction need removing?
@bors bors merged commit e6f7f23 into rust-lang:master Jan 16, 2015
@aidanhs aidanhs deleted the aphs-doc-vec-heap branch August 26, 2015 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants