librustc: hint close matches on accessing nonexisting fields #21187
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
oli-obk
force-pushed
the
feature/hint_struct_field_access
branch
2 times, most recently
from
59241c8 to
9cd90f7
Compare
| @@ -3572,11 +3573,44 @@ fn check_expr_with_unifier<'a, 'tcx, F>(fcx: &FnCtxt<'a, 'tcx>, | |||
| actual) | |||
| }, | |||
| expr_t, None); | |||
| if let Some(t) = ty::ty_to_def_id(expr_t) { | |||
| suggest_field_names(t, field, tcx, vec![]); | |||
| } | |||
There was a problem hiding this comment.
Could you add a test for this error message as well?
There was a problem hiding this comment.
sure, allthough the test is not (yet) useful since it's ignored: #21195
oli-obk
force-pushed
the
feature/hint_struct_field_access
branch
3 times, most recently
from
9f085cc to
c8d68a7
Compare
|
rebased on master, added test and changed number of help messages to one. local make check-stage1 passes, make check is running right now |
|
make check passed |
|
Thanks! Could you squash the commits together as well? |
oli-obk
force-pushed
the
feature/hint_struct_field_access
branch
from
c8d68a7 to
b24da87
Compare
|
i just left them there for easier reading. |
|
@bors: r+ b24da87 |
|
⌛ Testing commit b24da87 with merge b63cc5c... |
|
💔 Test failed - auto-mac-64-opt |
oli-obk
force-pushed
the
feature/hint_struct_field_access
branch
from
b24da87 to
09d9924
Compare
|
sorry about that. fixed, rebased and make check ran through |
|
@bors: r+ 09d9924 |
…excrichton rebase and fix of #19267
|
⌛ Testing commit 09d9924 with merge b7930d9... |
rebase and fix of #19267