std: Move the bitflags! macro to a gated crate #21254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @aturon |
bors
referenced
this pull request
Jan 16, 2015
alexcrichton
force-pushed
the
no-more-bitflags
branch
from
94e0520 to
05787c2
Compare
In accordance with [collections reform part 2][rfc] this macro has been moved to an external [bitflags crate][crate] which is [available though crates.io][cratesio]. Inside the standard distribution the macro has been moved to a crate called `rustc_bitflags` for current users to continue using. [rfc]: https://github.com/rust-lang/rfcs/blob/master/text/0509-collections-reform-part-2.md [crate]: https://github.com/rust-lang/bitflags [cratesio]: http://crates.io/crates/bitflags The major user of `bitflags!` in terms of a public-facing possibly-stable API today is the `FilePermissions` structure inside of `std::io`. This user, however, will likely no longer use `bitflags!` after I/O reform has landed. To prevent breaking APIs today, this structure remains as-is. Current users of the `bitflags!` macro should add this to their `Cargo.toml`: bitflags = "0.1" and this to their crate root: #[macro_use] extern crate bitflags; Due to the removal of a public macro, this is a: [breaking-change]
alexcrichton
force-pushed
the
no-more-bitflags
branch
from
05787c2 to
6cf157f
Compare
bors
added a commit
that referenced
this pull request
Jan 17, 2015
std: Move the bitflags! macro to a gated crate Reviewed-by: aturon
bors
referenced
this pull request
Jan 17, 2015
bors
added a commit
that referenced
this pull request
Jan 17, 2015
std: Move the bitflags! macro to a gated crate Reviewed-by: aturon
bors
referenced
this pull request
Jan 17, 2015
|
Doing this manually as part of #21300 |
fantix
added a commit
to fantix/nix-rust
that referenced
this pull request
Jan 18, 2015
fantix
added a commit
to fantix/mio
that referenced
this pull request
Jan 18, 2015
fantix
added a commit
to fantix/mio
that referenced
this pull request
Jan 18, 2015
little-arhat
pushed a commit
to little-arhat/nix-rust
that referenced
this pull request
Feb 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with collections reform part 2 this macro has been moved to
an external bitflags crate which is available though
crates.io. Inside the standard distribution the macro has been moved
to a crate called
rustc_bitflagsfor current users to continue using.The major user of
bitflags!in terms of a public-facing possibly-stable APItoday is the
FilePermissionsstructure inside ofstd::io. This user,however, will likely no longer use
bitflags!after I/O reform has landed. Toprevent breaking APIs today, this structure remains as-is.
Current users of the
bitflags!macro should add this to theirCargo.toml:and this to their crate root:
Due to the removal of a public macro, this is a:
[breaking-change]