Use singular they in the serialize::json docs #21314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [https://gist.github.com/0xabad1dea/8870b192fd1758743f66](this document) by @0xabad1dea for the rationale.
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
I'm not sure why my commit is moving the |
|
thank you very much! r=me after that change is fixed |
|
@steveklabnik done |
|
Thanks so much! |
bors
added a commit
that referenced
this pull request
Jan 17, 2015
Use singular they in the serialize::json docs Reviewed-by: steveklabnik
bors
referenced
this pull request
Jan 17, 2015
Brings the rustdoc man page in sync with the options specified in src/librustdoc/lib.rs. The text was taken verbatim, but I tweaked the order to be (what I think is) somewhat logical.
|
💖 |
bors
added a commit
that referenced
this pull request
Jan 18, 2015
Use singular they in the serialize::json docs Reviewed-by: steveklabnik
bors
referenced
this pull request
Jan 18, 2015
bors
added a commit
that referenced
this pull request
Jan 18, 2015
Use singular they in the serialize::json docs Reviewed-by: steveklabnik
bors
referenced
this pull request
Jan 18, 2015
|
⌛ Testing commit 5aa2f9c with merge 7e276cd... |
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: retry |
|
@bors rollup |
barosl
added a commit
to barosl/rust
that referenced
this pull request
Jan 20, 2015
See [this document](https://gist.github.com/0xabad1dea/8870b192fd1758743f66) by @0xabad1dea for the rationale.
fenhl
added a commit
to fenhl/rustc-serialize
that referenced
this pull request
Mar 7, 2015
Same as rust-lang/rust#21314 but for rustc-serialize instead of serialize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this document by @0xabad1dea for the rationale.