-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsyntax: fix for has_test_signature
#21504
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
@bors: r- er actually, could you add a test for this case as well? |
@alexcrichton Not sure that github notifies about added commits. re-r? |
@bors: r+ fd02920 rollup Thanks! |
…=alexcrichton Fix for `error: functions used as tests must have signature fn() -> ()` and `error: functions used as benches must have signature `fn(&mut Bencher) -> ()` in case of explicit return type declaration.
…=alexcrichton Fix for `error: functions used as tests must have signature fn() -> ()` and `error: functions used as benches must have signature `fn(&mut Bencher) -> ()` in case of explicit return type declaration.
@alexcrichton I have just fixed the test. Another WCPGW problem, sorry.. |
Needs a rebase |
Fix for
error: functions used as tests must have signature fn() -> ()
anderror: functions used as benches must have signature fn(&mut Bencher) -> ()
in case of explicit return type declaration.Currently
will produce:
which is definitely wrong.