Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_until reworked so returned delimiter is explicit #21514

Closed
wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 22, 2015

read_line never returns '\n' character
read_until returns enum signifying whether delimiter is returned or not

not sure if this requires an rfc, the enum name is certainly bikesheddable.

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

read_line never returns '\n' character
read_until returns enum signifying whether delimiter is returned or not
@alexcrichton
Copy link
Member

Thanks for the PR! This is actively being redesigned as part of the I/O reform RFCs, however. Would you mind adding some comments to the relevant RFC instead?

We're currently going to largely freeze the current I/O system in order to prevent future breakage with it. We hope to take all known feedback into account with the upcoming I/O system (spelled out in RFCs), so please leave some feedback!

@oli-obk oli-obk deleted the better_read_line branch January 23, 2015 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants