Correct type inference failure uncovered by japaric #21523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e by-product within. Fixes rust-lang#19499.
|
This looks good to me 🍰 |
|
@bors r+ 6bb3a29 |
|
@bors r=eddyb 45bca4315b5150b393bd8ea8080213d5bf48e5ed |
|
⌛ Testing commit 45bca43 with merge fdc7ecb... |
|
💔 Test failed - auto-mac-64-opt |
|
The compile-fail failures seem to be caused by inference getting further than before. |
…de much easier to read.
UFCS form. In both cases the problems came about because we were failing to process pending trait obligations. So change code to process pending trait obligations before coercions to ensure maximum type information is available (and also adjust shift to do something similar). Fixes rust-lang#21245.
nikomatsakis
force-pushed
the
issue-21245-japaric-ti-failure
branch
from
45bca43 to
8d6786c
Compare
|
⌛ Testing commit 8d6786c with merge 3d8a070... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes some miscellaneous cleanup. This is kind of a band-aid but it fixes the problems @japaric was encountering.
r? @eddyb