Skip to content

std: Relax Result::unwrap() to Debug #21558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2015
Merged

Conversation

alexcrichton
Copy link
Member

This commit relaxes the bound on Result::unwrap and Result::unwrap_err from
the Display trait to the Debug trait for generating an error message about
the unwrapping operation.

This commit is a breaking change and any breakage should be mitigated by
ensuring that Debug is implemented on the relevant type.

[breaking-change]

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned nikomatsakis Jan 23, 2015
@aturon
Copy link
Member

aturon commented Jan 23, 2015

@bors: r+ 0370af6

This commit relaxes the bound on `Result::unwrap` and `Result::unwrap_err` from
the `Display` trait to the `Debug` trait for generating an error message about
the unwrapping operation.

This commit is a breaking change and any breakage should be mitigated by
ensuring that `Debug` is implemented on the relevant type.

[breaking-change]
@alexcrichton
Copy link
Member Author

@bors: r=aturon 0924652

@bors
Copy link
Collaborator

bors commented Jan 23, 2015

🙀 You have the wrong number! Please try again with 0824652.

@alexcrichton
Copy link
Member Author

@bors: r=aturon 0824652

bors added a commit that referenced this pull request Jan 25, 2015
This commit relaxes the bound on `Result::unwrap` and `Result::unwrap_err` from
the `Display` trait to the `Debug` trait for generating an error message about
the unwrapping operation.

This commit is a breaking change and any breakage should be mitigated by
ensuring that `Debug` is implemented on the relevant type.

[breaking-change]
@bors
Copy link
Collaborator

bors commented Jan 25, 2015

⌛ Testing commit 0824652 with merge 43046be...

@bors bors merged commit 0824652 into rust-lang:master Jan 25, 2015
@alexcrichton alexcrichton deleted the result-debug branch February 4, 2015 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants