Cleanup check_cast. Fixes #21554 #21606
Merged
+119
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes the cast error messages somewhat more uniform.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -3128,7 +3128,6 @@ pub fn type_is_scalar(ty: Ty) -> bool { | |||
| ty_bool | ty_char | ty_int(_) | ty_float(_) | ty_uint(_) | | |||
| ty_infer(IntVar(_)) | ty_infer(FloatVar(_)) | | |||
| ty_bare_fn(..) | ty_ptr(_) => true, | |||
| ty_tup(ref tys) if tys.is_empty() => true, | |||
There was a problem hiding this comment.
It seems to me that this might have non-local consequence, beyond just changing these error messages slightly, maybe just changing the internals of the cast checking would be more reliable?
There was a problem hiding this comment.
Unit structs aren't scalars. Unit enums aren't scalars. ((),) isn't a scalar. I checked the other places that use this function – they don't care.
|
r? @huonw |
|
@bors: r+ e724525 |
bors
added a commit
that referenced
this pull request
Jan 26, 2015
This also makes the cast error messages somewhat more uniform.
|
⌛ Testing commit e724525 with merge a637365... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes the cast error messages somewhat more uniform.