Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup depricated uint in rand/mod.rs and rand/os.rs #21676

Merged
merged 2 commits into from
Jan 28, 2015

Conversation

Victory
Copy link
Contributor

@Victory Victory commented Jan 27, 2015

Cleanup mention of uint, use usize/us instead. This includes the example println!("{}", 2u * x);

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@@ -99,10 +99,10 @@
//! let between = Range::new(-1f64, 1.);
//! let mut rng = rand::thread_rng();
//!
//! let total = 1_000_000u;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be possible to just remove most of the suffixes, could you try that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i can remove those.

@alexcrichton
Copy link
Member

@bors: r+ ac285d5 rollup

Thanks!

barosl added a commit to barosl/rust that referenced this pull request Jan 27, 2015
…r=alexcrichton

Cleanup mention of uint, use usize/us instead. This includes the example `println!("{}", 2u * x);`
Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 27, 2015
…r=alexcrichton

Cleanup mention of uint, use usize/us instead. This includes the example `println!("{}", 2u * x);`
@bors bors merged commit ac285d5 into rust-lang:master Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants