Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot + s/range(a, b)/a..b/g + s/Show/Debug/g cleanup #21677

Merged
merged 11 commits into from
Jan 29, 2015

Conversation

japaric
Copy link
Member

@japaric japaric commented Jan 27, 2015

Note: Do not merge until we get a newer snapshot that includes #21374

There was some type inference fallout (see 4th commit) because type inference with a..b is not as good as with range(a, b) (see #21672).

r? @alexcrichton

@alexcrichton
Copy link
Member

r=me whenever this is ready, nice work @japaric
c!

cc @aturon, we may be able to remove range from the prelude soon (or at least deprecated it). May want to get #21672 dealt with though.

@japaric japaric changed the title cleanup: s/range(a, b)/a..b/g snapshot + s/range(a, b)/a..b/g + s/Show/Debug/g cleanup Jan 28, 2015
@alexcrichton
Copy link
Member

r=me with a deprecation warning about derive(Show) (talked about on IRC)

@japaric
Copy link
Member Author

japaric commented Jan 28, 2015

@bors: r=alexcrichton 9b8f07f

@tshepang
Copy link
Member

I see a bunch of u suffixes which should be us.

@japaric
Copy link
Member Author

japaric commented Jan 28, 2015

@tshepang yes, there are bunch of places where the i/u suffixes are still being used. I sticked to either keep the suffix as it is, or add either u/us based on what the surrounding code was using. I think someone was already working on/sent a PR updating the suffixes though. If not, it can be done afterwards :-).

@japaric
Copy link
Member Author

japaric commented Jan 28, 2015

@bors: r=alexcrichton 642a4a1

bors added a commit that referenced this pull request Jan 29, 2015
Note: Do not merge until we get a newer snapshot that includes #21374

There was some type inference fallout (see 4th commit) because type inference with `a..b` is not as good as with `range(a, b)` (see #21672).

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Jan 29, 2015

⌛ Testing commit 642a4a1 with merge 18b53c1...

@bors
Copy link
Collaborator

bors commented Jan 29, 2015

💔 Test failed - auto-win-32-opt

@alexcrichton
Copy link
Member

@bors: retry

@japaric
Copy link
Member Author

japaric commented Jan 29, 2015

@bors: r=alexcrichton a6f9180

@bors
Copy link
Collaborator

bors commented Jan 29, 2015

⌛ Testing commit a6f9180 with merge 265a233...

bors added a commit that referenced this pull request Jan 29, 2015
Note: Do not merge until we get a newer snapshot that includes #21374

There was some type inference fallout (see 4th commit) because type inference with `a..b` is not as good as with `range(a, b)` (see #21672).

r? @alexcrichton
@bors bors merged commit a6f9180 into rust-lang:master Jan 29, 2015
@japaric japaric deleted the no-range branch January 30, 2015 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants