Add a few missing stability attributes #21745
Conversation
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -45,6 +45,7 @@ macro_rules! try_opt { | |||
|
|
|||
| /// ISO 8601 time duration with nanosecond precision. | |||
| /// This also allows for the negative duration; see individual methods for details. | |||
| #[unstable(feature = "std_misc")] | |||
There was a problem hiding this comment.
Adding #![feature(std_misc)] seems to already make this type available, did some code you have not compile with the feature gate?
There was a problem hiding this comment.
It was only HashState that I found myself unable to use; I didn’t try any of the rest. But still, they should have these markers, should they not?
There was a problem hiding this comment.
Ah this was probably a vicitm of inheritance. An #[unstable] attribute is inherited by all children by default. The entire std::time::duration module is marked #[unstable] (which this inherits), but the hash_map module is not unstable and Hasher was just erroneously missing a marker.
chris-morgan
force-pushed
the
add-missing-unstable-attributes
branch
from
2f8d6b0 to
9836742
Compare
|
Note: this is currently blocking Servo's rustup. cc @SimonSapin |
|
Fixes #21883. |
|
@bors r+ 9836 p=1 |
…r=huonw I’d kind of like to be able to use HashState in AnyMap, which I can’t do without a stability attribute on it. While I was at it I looked around and found a few more missing.
I’d kind of like to be able to use HashState in AnyMap, which I can’t do without a stability attribute on it. While I was at it I looked around and found a few more missing.
Closes #21883.