Fix memory unsafety in Reader::push
by simply removing it
#21902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory unsafety was caused by the fact that it passed an uninitialized
buffer to a different function (
Reader::read
) which might not give the(unsafe) guarantee that it doesn't touch the uninitalized bytes.
If one removes this unsafety, the function is no better than creating an
initialized vector and passing it to the
Reader::read
function, so it wasremoved completely.
Fixes #21896.