Error when #![staged_api] crates are missing stability markers
#21910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
missing_stability
branch
from
56a94c9 to
8e99079
Compare
| } | ||
|
|
||
| impl<'a> Annotator<'a> { | ||
| // Determine the stability for a node based on its attributes and inherited | ||
| // stability. The stability is recorded in the index and used as the parent. | ||
| fn annotate<F>(&mut self, id: NodeId, use_parent: bool, | ||
| attrs: &Vec<Attribute>, item_sp: Span, f: F) where | ||
| attrs: &Vec<Attribute>, item_sp: Span, f: F, error: bool) where |
There was a problem hiding this comment.
Can error be renamed to something more descriptive: required
Manishearth
force-pushed
the
missing_stability
branch
3 times, most recently
from
42d0cff to
d02d4c3
Compare
|
I tweaked it so that it ignores errors when compiling tests. We don't need errors about testing when there are A more fine-grained option is to make the visitor not recurse for |
|
Nice work, @Manishearth! cc @SimonSapin |
|
\o/ |
|
Fixes #21884 |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 4, 2015
Currently, if a `#![staged_api]` crate contains an exported item without a stability marker (or inherited stability), the item is useless. This change introduces a check to ensure that all exported items have a defined stability. it also introduces the `unmarked_api` feature, which lets users import unmarked features. While this PR should in theory forbid these from existing, in practice we can't be so sure; so this lets users bypass this check instead of having to wait for the library and/or compiler to be fixed (since otherwise this is a hard error). r? @aturon
1 task
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a
#![staged_api]crate contains an exported item without a stability marker (or inherited stability),the item is useless.
This change introduces a check to ensure that all exported items have a defined stability.
it also introduces the
unmarked_apifeature, which lets users import unmarked features. While this PR should in theory forbid these from existing,in practice we can't be so sure; so this lets users bypass this check instead of having to wait for the library and/or compiler to be fixed (since otherwise this is a hard error).
r? @aturon