Made external_crates feature work again. #21966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -78,7 +78,6 @@ | |||
| #[macro_use] | |||
| extern crate core; | |||
|
|
|||
| #[cfg(all(not(feature = "external_funcs"), not(feature = "external_crate")))] | |||
There was a problem hiding this comment.
That removes the error but links to libc instead. Adding #[allow(unused_features)] is a way better 'fix' (it still allows it globally...) without introducing a pointless platform specific dependency. IMHO the real problem is that it isn't possible to add #![feature(libc)] only when no other features are present...
Also added test for it. Fixes rust-lang#21928
|
@alexcrichton Could I get just a regular r+, This is a bug that actually breaks some code... |
|
@bors: rollup- Sure thing! |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 6, 2015
Also added test for it. Fixes rust-lang#21928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added test for it.
Fixes #21928