Improve core::cmp docs #21990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

huonw merged 1 commit into rust-lang:master from steveklabnik:doc_core_cmp

Feb 18, 2015

Contributor

steveklabnik commented Feb 6, 2015

Fix up, add examples, make them all the same.

rust-highfive assigned aturon

Contributor

rust-highfive commented Feb 6, 2015

(rust_highfive has picked a reviewer for you, use r? to override)

nagisa reviewed

View reviewed changes

src/libcore/cmp.rs Outdated

Member

nagisa Feb 6, 2015

I think s/and so/therefore/ would sound better here.

steveklabnik force-pushed the doc_core_cmp branch from 7be82c7 to 2307a5c Compare

February 8, 2015 22:53

Contributor Author

steveklabnik commented Feb 8, 2015

Feedback addressed.

huonw reviewed

View reviewed changes

src/libcore/cmp.rs Outdated

Contributor

huonw Feb 11, 2015

Maybe s/Traits/Functionality/ since there's things other than traits? (I could just be overly nit-picky)

steveklabnik force-pushed the doc_core_cmp branch 2 times, most recently from bc812af to c378c07 Compare

February 11, 2015 03:29

huonw reviewed

View reviewed changes

src/libcore/cmp.rs Outdated

Contributor

huonw Feb 11, 2015

s/is often/can be/

steveklabnik force-pushed the doc_core_cmp branch from c378c07 to 679f6a4 Compare

February 11, 2015 03:34

huonw reviewed

View reviewed changes

src/libcore/cmp.rs

Contributor

huonw Feb 11, 2015

Similarly these could demonstrate returning None, also using NaN.

(Totally minor: Is there a reason that these ones have cmp::partial_min(2, 2) but the non-partial ones don't?)

Contributor Author

steveklabnik Feb 11, 2015

I thought I was making them all the same, but it's possible that i just screwed tha tup

steveklabnik force-pushed the doc_core_cmp branch 2 times, most recently from 956558f to 7c63cd1 Compare

February 11, 2015 03:37

huonw reviewed

View reviewed changes

src/libcore/cmp.rs

Contributor

huonw Feb 11, 2015

This could have a NaN example too.

Contributor Author

steveklabnik Feb 11, 2015

truth. fixed!

steveklabnik force-pushed the doc_core_cmp branch from 7c63cd1 to 3d06e91 Compare

February 11, 2015 04:31

huonw reviewed

View reviewed changes

src/libcore/cmp.rs Outdated

Contributor

huonw Feb 11, 2015

This and partial_max should be function calls, not methods.

steveklabnik force-pushed the doc_core_cmp branch from 3d06e91 to 17f9d36 Compare

February 13, 2015 13:49


          Improve core::cmp docs

17f9d36

Contributor Author

steveklabnik commented Feb 13, 2015

@huonw should be good to go now

Contributor

huonw commented Feb 16, 2015

@bors r+ 17f9 rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request


          Rollup merge of rust-lang#21990 - steveklabnik:doc_core_cmp, r=huonw

522091e

Fix up, add examples, make them all the same.

Manishearth mentioned this pull request

Rollup of 20 pull requests #22439

Closed

huonw merged commit 17f9d36 into rust-lang:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet