Make the live code analysis visit method declarations. #22048
Conversation
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
LeoTestard
force-pushed
the
impl-patterns-used
branch
from
c058e20 to
5c15692
Compare
|
@bors r+ 5c15692 |
|
⌛ Testing commit 5c15692 with merge ce01c45... |
|
💔 Test failed - auto-mac-64-opt |
|
@LeoTestard looks like there's something wrong with your test setup. Why did you make this a |
|
@pnkfelix It's supposed to type-check. I made this a this looks like the test is built as a lib. I think I need to make |
LeoTestard
force-pushed
the
impl-patterns-used
branch
2 times, most recently
from
b1bd387 to
1ab44f4
Compare
|
@LeoTestard ah yes, I did not read the error message (or the test) carefully enough, sorry. |
|
@bors r+ 1ab44f4 rollup |
1 similar comment
|
@bors r+ 1ab44f4 rollup |
|
@pnkfelix np. I don't really understand what this |
|
@LeoTestard actually, reviewing the log again, I'm not convinced making |
|
@bors r- |
|
@pnkfelix Allright, this is not really urgent anyway... |
LeoTestard
force-pushed
the
impl-patterns-used
branch
from
1ab44f4 to
2a46de4
Compare
|
(leo and I discussed in Update: @alexcrichton pointed out the use of |
The live code analysis only visited the function's body when visiting a method, and not the FnDecl and the generics, resulting in code to be incorrectly marked as unused when it only appeared in the generics, the arguments, or the return type, whereas the same code in non-method functions was correctly detected as used. Fixes rust-lang#20343.
LeoTestard
force-pushed
the
impl-patterns-used
branch
from
2a46de4 to
73201fd
Compare
|
Run the tests locally and it went well (except failures in the run-pass-fulldeps suite that reported symbol lookup errors... probably a problem of dynamic loading, seems unrelated with this PR). I think we can retry to merge it. |
…kfelix The live code analysis only visited the function's body when visiting a method, and not the FnDecl and the generics, resulting in code to be incorrectly marked as unused when it only appeared in the generics, the arguments, or the return type, whereas the same code in non-method functions was correctly detected as used. Fixes rust-lang#20343. Originally I just added a call to `walk_generics` and `walk_fndecl` alongside `walk_block` but then I noticed the `walk_method_helper` function did pretty much the same thing. The only difference is that it also calls `visit_mac`, but since this is not going to happen at this stage, I think it's ok. However let me know if this was not the right thing to do.
The live code analysis only visited the function's body when visiting a method, and not the FnDecl and the generics, resulting in code to be incorrectly marked as unused when it only appeared in the generics, the arguments, or the return type, whereas the same code in non-method functions was correctly detected as used. Fixes rust-lang#20343. Originally I just added a call to `walk_generics` and `walk_fndecl` alongside `walk_block` but then I noticed the `walk_method_helper` function did pretty much the same thing. The only difference is that it also calls `visit_mac`, but since this is not going to happen at this stage, I think it's ok. However let me know if this was not the right thing to do.
The live code analysis only visited the function's body when visiting a
method, and not the FnDecl and the generics, resulting in code to be
incorrectly marked as unused when it only appeared in the generics, the
arguments, or the return type, whereas the same code in non-method
functions was correctly detected as used. Fixes #20343.
Originally I just added a call to
walk_genericsandwalk_fndeclalongsidewalk_blockbut then I noticed thewalk_method_helperfunction did pretty much the same thing. The only difference is that it also callsvisit_mac, but since this is not going to happen at this stage, I think it's ok. However let me know if this was not the right thing to do.