Do not fail if --emit≠link and there’s no main fn #22051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Could you also add a test for this? I suppose it could lead to weird errors if you're generating an object file (or generating IR and then using that to make an object later), but it seems like this may be worth it. |
|
@alexcrichton done. |
|
⌛ Testing commit 61b4823 with merge 684944f... |
|
💔 Test failed - auto-win-64-nopt-t |
|
@bors: retry |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 10, 2015
nagisa
added a commit
to nagisa/rust
that referenced
this pull request
Feb 11, 2015
This resulted in some very unexpected fallout such as empty llvm-ir, llvm-bc and asm in some cases. See rust-lang#22183 for related info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21813