Add quasiquote for matchers and attributes #22061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
pczarn
force-pushed
the
quote_matcher_and_attr
branch
from
5a61750
to
1c7aafa
Compare
|
r? @kmcallister |
| vec!(e_tok)); | ||
| vec!(cx.stmt_expr(e_push)) | ||
| } else { | ||
| panic!("TtSequence in quote!") |
There was a problem hiding this comment.
Could you move this to the top as
if !matcher {
panic!("TtSequence in quote!");
}and then un-indent the bulk of the code?
pczarn
force-pushed
the
quote_matcher_and_attr
branch
2 times, most recently
from
d75fbf5
to
4e355e2
Compare
|
r=me with those two things |
pczarn
force-pushed
the
quote_matcher_and_attr
branch
from
4e355e2
to
3541abe
Compare
|
Updated, tested. |
|
⌛ Testing commit 3541abe with merge 7350162... |
|
(I might be forcebuilding the rollup, so the build may fail a couple of times here, sorry in advance) |
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: retry |
|
In case the rollup causes a merge conflict, here is the fix: 290caba |
bors
added a commit
that referenced
this pull request
Mar 5, 2015
Fixes #19674 Fixes #17396 (already closed, yeah) cc @kmcallister , @cmr
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19674
Fixes #17396 (already closed, yeah)
cc @kmcallister , @cmr