Add documentation on trait objects. #22106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
❤️ (It's probably better if I don't review, given I wrote a lot of it.) |
|
Hehe, yeah, I thought about it, and decided to let @rust-highfive do its thing. The edits are actually very small. |
| binary, one for each type. | ||
|
|
||
| Furthermore, compilers aren’t perfect and may “optimise” code to become slower. | ||
| For example, functions inlined too eagerly will bloating the instruction cache |
|
Nice! A few small nits and otherwise r=me |
steveklabnik
force-pushed
the
doc_trait_objects
branch
from
4de5b3f to
dbccd70
Compare
|
|
||
| However, the common case is that it is more efficient to use static dispatch, | ||
| and one can always have a thin statically-dispatched wrapper function that does | ||
| a dynamic, but not vice versa, meaning static calls are more flexible. The |
There was a problem hiding this comment.
s/does a dynamic/does a dynamic call/?
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 10, 2015
…lexcrichton I started to write up some docs on this, and then realized I was just repeating http://huonw.github.io/blog/2015/01/peeking-inside-trait-objects/ but worse. @huonw previously said that we can use this content if we wanted, so I made some tweaks and integrated it into the book. Fixes rust-lang#21707
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 10, 2015
I started to write up some docs on this, and then realized I was just repeating http://huonw.github.io/blog/2015/01/peeking-inside-trait-objects/ but worse. @huonw previously said that we can use this content if we wanted, so I made some tweaks and integrated it into the book. Fixes rust-lang#21707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to write up some docs on this, and then realized I was just repeating http://huonw.github.io/blog/2015/01/peeking-inside-trait-objects/ but worse. @huonw previously said that we can use this content if we wanted, so I made some tweaks and integrated it into the book.
Fixes #21707